Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/c++] Deprecate config_options_from_schema in favor of new function #3437

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Dec 13, 2024

  • Create new PlatformSchemaConfig class with only TileDB schema properties
  • Create new method schema_config_options that returns the PlatformSchemaConfig.

* Create new `PlatformSchemaConfig` class with only TileDB schema properties
* Create new method `schema_config_options` that returns the
  `PlatformSchemaConfig`.
@jp-dark jp-dark requested review from nguyenv and johnkerl December 13, 2024 21:36
@jp-dark jp-dark marked this pull request as ready for review December 13, 2024 21:37
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.24%. Comparing base (8d92cb5) to head (7eac4b3).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3437      +/-   ##
==========================================
+ Coverage   86.22%   86.24%   +0.01%     
==========================================
  Files          55       55              
  Lines        6295     6301       +6     
==========================================
+ Hits         5428     5434       +6     
  Misses        867      867              
Flag Coverage Δ
python 86.24% <85.71%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.24% <85.71%> (+0.01%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@jp-dark jp-dark merged commit ddea64c into main Dec 17, 2024
15 checks passed
@jp-dark jp-dark deleted the dark/schema-config branch December 17, 2024 17:18
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
…unction (#3437)

* Create new `PlatformSchemaConfig` class with only TileDB schema properties.
* Create new method `schema_config_options` that returns the
  `PlatformSchemaConfig`.
* Deprecate `config_options_from_schema` in favor of `schema_config_options`.
johnkerl pushed a commit that referenced this pull request Dec 17, 2024
…unction (#3437) (#3465)

* Create new `PlatformSchemaConfig` class with only TileDB schema properties.
* Create new method `schema_config_options` that returns the
  `PlatformSchemaConfig`.
* Deprecate `config_options_from_schema` in favor of `schema_config_options`.

Co-authored-by: Julia Dark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants